Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #48: Use IssueCommentEvent's action in post msg #63

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Fix #48: Use IssueCommentEvent's action in post msg #63

merged 2 commits into from
Mar 25, 2019

Conversation

checkaayush
Copy link
Contributor

Fixes #48

@checkaayush
Copy link
Contributor Author

@jwilander this is ready for review.

@hanzei hanzei requested a review from jwilander March 24, 2019 18:57
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 24, 2019
@jwilander jwilander requested a review from hanzei March 25, 2019 13:43
@jwilander
Copy link
Member

Hmmm this will work but I wonder if it would be better to just not send a notification for this case? Does anybody really want notifications when someone deletes a comment?

hanzei
hanzei reviewed Mar 25, 2019
View reviewed changes
server/webhook.go Outdated Show resolved Hide resolved
@hanzei
Copy link
Contributor

hanzei commented Mar 25, 2019

I agree. We should just filter out edited and deleted as action's.

@checkaayush
Copy link
Contributor Author

I agree. We should just filter out edited and deleted as action's.

Done with the change. Ready for final review. @hanzei

jwilander
jwilander approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jwilander jwilander merged commit 5890626 into mattermost:master Mar 25, 2019
@checkaayush checkaayush deleted the fixCommentBehavior branch March 25, 2019 16:39
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 25, 2019
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this pull request Feb 8, 2021
MM-29124 Change the default filestore to non-multitenant on E10/E0 (m…
698c786 
…attermost#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@checkaayush @jwilander @hanzei