-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy to GH when tag a release #60
Conversation
/check-cla |
I'm not sure we want this, I'd much rather have manual control over the releases so that we can fill in the changelog |
@jwilander you will need to create the tag, upload the plugin and after you will need to add the changelog. This PR reduce in one step which will upload the release when you tag. I can research a bit later in the near future if we can automatize the changelog in the GH release. |
I honestly prefer a manual changelog at this point. One based solely off the commit messages is likely to be unclear |
I was thinking in a changelog file that you commit and we have some script which parses that :) @jwilander |
That would be fine with me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM
I would like to discuss the changelog idea with a broader audience. Would you mind proposing your idea in ~Developers-Toolkit? |
@hanzei I can add a post when i have some ideas, for now i dont have any :) |
Re Changelog: To be fair, we wont release plugin so often. 👍 for automation in general, but I don't think this is a big topic ATM. |
Adding a functionality to deploy to GH when we tag a release