Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy to GH when tag a release #60

Merged
merged 3 commits into from
Mar 11, 2019
Merged

deploy to GH when tag a release #60

merged 3 commits into from
Mar 11, 2019

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Mar 10, 2019

Adding a functionality to deploy to GH when we tag a release

@cpanato cpanato added the 2: Dev Review Requires review by a core committer label Mar 10, 2019
@cpanato cpanato closed this Mar 10, 2019
@cpanato cpanato reopened this Mar 10, 2019
@cpanato
Copy link
Contributor Author

cpanato commented Mar 10, 2019

/check-cla

@jwilander
Copy link
Member

I'm not sure we want this, I'd much rather have manual control over the releases so that we can fill in the changelog

@cpanato
Copy link
Contributor Author

cpanato commented Mar 11, 2019

@jwilander you will need to create the tag, upload the plugin and after you will need to add the changelog. This PR reduce in one step which will upload the release when you tag.

I can research a bit later in the near future if we can automatize the changelog in the GH release.

@jwilander
Copy link
Member

I honestly prefer a manual changelog at this point. One based solely off the commit messages is likely to be unclear

@cpanato
Copy link
Contributor Author

cpanato commented Mar 11, 2019

I was thinking in a changelog file that you commit and we have some script which parses that :) @jwilander

@jwilander
Copy link
Member

That would be fine with me 👍

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

.circleci/config.yml Outdated Show resolved Hide resolved
@hanzei
Copy link
Contributor

hanzei commented Mar 11, 2019

I would like to discuss the changelog idea with a broader audience. Would you mind proposing your idea in ~Developers-Toolkit?

@cpanato
Copy link
Contributor Author

cpanato commented Mar 11, 2019

@hanzei I can add a post when i have some ideas, for now i dont have any :)

@hanzei
Copy link
Contributor

hanzei commented Mar 11, 2019

Re Changelog: To be fair, we wont release plugin so often. 👍 for automation in general, but I don't think this is a big topic ATM.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 11, 2019
@hanzei hanzei merged commit 3b80f07 into mattermost:master Mar 11, 2019
@cpanato cpanato deleted the deploy-to-gh-circleci branch March 11, 2019 15:24
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants