Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --exclude option to subscriptions command #418

Closed
jfrerich opened this issue Jan 20, 2021 · 7 comments · Fixed by #457 or #683
Closed

Add --exclude option to subscriptions command #418

jfrerich opened this issue Jan 20, 2021 · 7 comments · Fixed by #457 or #683
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go

Comments

@jfrerich
Copy link
Contributor

jfrerich commented Jan 20, 2021 •
edited by hanzei
Loading

Currently, subscriptions allow adding repositories or an organization to a subscription.

This request is to add a --exclude flag that will allow excluding repositories from the notification.

/github subscriptions add mattermost,label:"Severity/Critical" --exclude mattermost/mattermost-server,mattermost/mattermost-webapp

An example would be to subscribe a channel to all mattermost organization repositories but exclude the webapp, redux, and server repositories.
@jfrerich jfrerich added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Difficulty/2:Medium Medium ticket labels Jan 20, 2021
@hanzei hanzei added the Tech/Go label Jan 20, 2021
@balan2010
Copy link

Hi! I would like to work on this

@larkox larkox removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 8, 2021
@larkox
Copy link
Contributor

larkox commented Feb 8, 2021

All yours @balan2010 . Thanks!

@balan2010
Copy link

Cheers :-)

@jfrerich
Copy link
Contributor Author

Woohoo! Thanks, @balan2010! This feature will be so helpful

@balan2010
Copy link

No Worries.. About to start working on this issue

@hanzei hanzei added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 30, 2021
@sibasankarnayak sibasankarnayak mentioned this issue Jul 13, 2021
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jul 13, 2021
@hanzei hanzei linked a pull request Jul 13, 2021 that will close this issue
MM 418 - Add --exclude option to subscriptions command #418 #457
Merged
hanzei pushed a commit that referenced this issue Aug 20, 2021
@sibasankarnayak
MM 418 - Add --exclude option to subscriptions command #418 (#457)
943ee2f 
Co-authored-by: Siba sankar Nayak <[email protected]>
mickmister added a commit that referenced this issue Feb 1, 2022
@mickmister
Revert "MM 418 - Add --exclude option to subscriptions command #418 (#…
d2149e4 
…457)"

This reverts commit 943ee2f.
@mickmister mickmister mentioned this issue Feb 1, 2022
Merged
@hanzei hanzei reopened this Feb 9, 2022
@hanzei
Copy link
Contributor

hanzei commented Feb 9, 2022

Reopening as #457 has been reverted

@hanzei
Copy link
Contributor

hanzei commented Feb 9, 2022

@sanjaydemansol Assigning you as you are working on #505

@hanzei hanzei added this to the v2.2.0 milestone Feb 9, 2022
@hanzei hanzei removed this from the v2.2.0 milestone Sep 20, 2022
@Nityanand13 Nityanand13 mentioned this issue Mar 20, 2023
Merged
@mkdbns mkdbns moved this from Todo to In Progress in Brightscout Plugin Maintenance Apr 28, 2023
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Jun 12, 2023
Merged
@hanzei hanzei moved this from In Progress to Submitted in Brightscout Plugin Maintenance Jun 20, 2023
@hanzei hanzei linked a pull request Sep 29, 2023 that will close this issue
[GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
Merged
@github-project-automation github-project-automation bot moved this from Submitted / In Review to Done in Brightscout Plugin Maintenance Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
No milestone
6 participants
@larkox @jfrerich @balan2010 @hanzei @maisnamrajusingh @sanjaydemansol