Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

fix typo in readme #320

Closed
wants to merge 1 commit into from

Conversation

adam-golab
Copy link

I fixed one small typo in readme
Entreprise => Enterprise

@mattermod
Copy link
Contributor

Thanks @adam-golab for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@adam-golab
Copy link
Author

I don't want to provide all of my personal information like mailing address, phone number or Skype ID to fix only one typo in the readme. So if my personal data are necessary then please close this issue.

@pichouk
Copy link
Contributor

pichouk commented Oct 5, 2018

Understandable :)
I don't know how strong is the CLA policy for Mattermost (@jasonblais ?), I'll do the commit to fix the typo. Anyway, thanks for the report :)

@pichouk pichouk closed this Oct 5, 2018
pichouk added a commit that referenced this pull request Oct 5, 2018
Thanks @adam-golab for the report (#320)
@pichouk pichouk mentioned this pull request Oct 5, 2018
pichouk added a commit that referenced this pull request Oct 5, 2018
Thanks @adam-golab for the report (#320)
@jasonblais
Copy link
Contributor

@pichouk Generally all Mattermost contributions should have CLA signed :)

Thank you @adam-golab for the feedback though, will take it into consideration. If we were asking for your name, email and GitHub username, would you have been more open to signing the agreement?

@adam-golab
Copy link
Author

@jasonblais only name, email and GitHub username sound a lot better :)

Still, to be honest, I don't think that providing any additional data is necessary (you can get this information from commit data). It's hard to contribute, open PR with some reasonable changes by mistake. There is a description of contribution rules in MAINTENANCE.md file, there may be Code of Conduct described in another file.
So, for me, opening a PR means that you are familiar and agree with those rules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants