Add basic setup for unit testing components with sass files import #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @renjithgr, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
jespino
reviewed
Mar 19, 2021
| @@ -32,6 +32,9 @@ | |||
| "react-simplemde-editor": "^4.1.3" | |||
| }, | |||
| "jest": { | |||
| "moduleNameMapper": { | |||
jespino
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yesterday, I submitted a PR (#84) for adding email as an option for the property type. But I didn't write any unit tests as part of it, and @jespino agreed it is okay to submit the unit tests as a separate PR. This PR contains a basic unit test for the
propertyMenu.tsxfile I changed as part of yesterday's PR.I had to change the Jest config to provide a mock in place of
sassfiles imported by components.Once this PR is in, I would be happy to add more unit tests.