[GH-40] Add property type email #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @renjithgr, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
|
@renjithgr unit tests are really welcome, we want to have a good test coverage, we have implemented this without unit testing to move fast in this stage of the process, but we will add them for sure sooner than later. |
|
Thanks for your feedback, @jespino. Let me know if you want me to add unit tests in this PR or you want to go ahead without unit tests for now. I would be happy to raise another PR to add unit tests. |
|
@renjithgr Lets merge this in, and add the unit tests in another PR. :) |
jespino
approved these changes
Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the option to choose email as a field type.
Ticket Link
#40
Most of the components are not covered by unit tests, including the ones I changed. So I was not sure what strategy the creators have in mind for unit testing components. Please advise. I would be happy to add unit tests.
Thank you!