Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in the gitlab, servicenow and jira plugin documentation after migration #7150

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented May 22, 2024

Summary

This PR makes some cleanup changes in the documentation of the GitLab, ServiceNow, and Jira plugins.

@Kshitij-Katiyar Kshitij-Katiyar changed the title Update in the gitlab documentation after migration Updates in the gitlab documentation after migration May 22, 2024
@Kshitij-Katiyar Kshitij-Katiyar changed the title Updates in the gitlab documentation after migration Updates in the gitlab and jira plugin documentation after migration May 23, 2024
@Kshitij-Katiyar Kshitij-Katiyar changed the title Updates in the gitlab and jira plugin documentation after migration Updates in the gitlab, servicenow and jira plugin documentation after migration May 23, 2024
@mickmister mickmister self-requested a review May 24, 2024 16:50
@mickmister
Copy link
Contributor

Big thanks for this PR @Kshitij-Katiyar 👍 Do you mind giving this PR a review to get another pair of eyes on it? #7148

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Kshitij-Katiyar 🎉

@mickmister mickmister requested a review from cwarnermm May 30, 2024 16:46
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided editorial feedback inline.

source/integrate/jira-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/servicenow-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/gitlab-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/gitlab-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/jira-interoperability.rst Outdated Show resolved Hide resolved
source/integrate/jira-interoperability.rst Outdated Show resolved Hide resolved
@cwarnermm cwarnermm self-requested a review June 6, 2024 15:14
@cwarnermm
Copy link
Member

@Kshitij-Katiyar - Please update this fork with latest master

@cwarnermm cwarnermm added the 3: Reviews Complete All reviewers have approved the pull request label Jun 10, 2024
@cwarnermm
Copy link
Member

@Kshitij-Katiyar - This fork is out of date with the master branch of the docs repository. Please update this fork with latest, and then mention me. I'll ensure the PR is merged into the code base. Thanks!

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar - This fork is out of date with the master branch of the docs repository. Please update this fork with the latest, and then mention me. I'll ensure the PR is merged into the code base. Thanks!

@cwarnermm Fixed the review comments as well as synced the forked branch

@cwarnermm cwarnermm merged commit a2dc9b0 into mattermost:master Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants