-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #906
Upgrade dependencies #906
Conversation
Looks good to me.
|
135cae0
to
3bfb9d6
Compare
Rebased against the latest master branch. Artifacts: https://circleci.com/gh/yuya-oc/desktop/1211#artifacts |
Added Electron v4. As far as reading the release notes, I could not find critical changes for us (However v5 will break the app due to default webPreferences values). Artifacts: https://circleci.com/gh/yuya-oc/desktop/1215#artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build succeeded on my Windows 10 Pro x64 1809 dev machine.
The build succeeded on AppVeyor as well BUT only 1 test is failing. Could we please fix this before merging this pull request?
Here are the AppVeyor logs with the details of the failing test: https://ci.appveyor.com/project/wget/mattermost-desktop/builds/21360791
Also, for a reason I don't know (even if this is NOT a regression) I realized the GUI on Windows was blurry compared to the web ui on the left:
I checked by disabling the GPU rendering, but without any improvement. Are we aware of this issue? Is a dedicated bug report already open?
e59ef9c
to
e62f16a
Compare
@wget Updated the branch. What about this? For blurry rendering, I think it's known issue (#560, electron/electron#10025). The reason is that Electron's webview unexpectedly uses grayscale antialiasing. It looks like blurry. |
@yuya-oc Everything worked like expected. The migration from yarn to npm went smoothly. All tests passed. Artefacts: https://ci.appveyor.com/project/wget/mattermost-desktop/builds/21505020 It's finally time to merge! |
Before submitting, please confirm you've
npm run lint:js
for proper code formattingPlease provide the following information:
Summary
Upgrade dependencies.
After this PR, we will get ready to switch back to npm.
Issue link
#898
Test Cases
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/1187#artifacts