Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #796

Merged
merged 8 commits into from
May 15, 2018
Merged

Update CHANGELOG.md #796

merged 8 commits into from
May 15, 2018

Conversation

amyblais
Copy link
Member

No description provided.

@amyblais amyblais requested review from yuya-oc and jasonblais May 11, 2018 16:27
@jasonblais jasonblais added this to the v4.1.0 milestone May 12, 2018
Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyblais Possibly you copied the changelog from #766, so some items might be unexpectedly removed. Would you take care also whether all items are listed?

CHANGELOG.md Outdated

#### Windows
- [Windows 7/8] Desktop notifications now respect the duration setting of Control Panel.
[#601](https://github.com/mattermost/desktop/issues/601)

### Architectural Changes
- Major version upgrade of Electron to v1.7.13 to v1.8.4. Electron is the underlying technology used to build the Desktop apps.
- Major version upgrade of Electron to v1.7.x to v1.8.x. Electron is the underlying technology used to build the Desktop apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "from v1.7.13 to v1.8.4".

CHANGELOG.md Outdated
[#711](https://github.com/mattermost/desktop/pull/711)
[#741](https://github.com/mattermost/desktop/pull/741)
<!-- Todo: Complete version number when cutting release -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed.

CHANGELOG.md Outdated
[#667](https://github.com/mattermost/desktop/issues/667)
- Fixed "Save Image" context menu not working.
[#707](https://github.com/mattermost/desktop/issues/707)
- Fixed an issue that prevented typing in the form fields on the add server dialog when launched from the tab bar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be removed.

CHANGELOG.md Outdated
[#774](https://github.com/mattermost/desktop/pull/774)
- Fixed an issue where tab outline disappeared when hovering over a tab.
[#778](https://github.com/mattermost/desktop/pull/778)
- Fixed an issue where only the name field should be highlighted and "Add" button shouldn't be disabled when a name was missing from "Add new server" dialog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, #779 improved the error message only.

@amyblais
Copy link
Member Author

Thank you @yuya-oc, Made requested changes and added back anything missing!

@yuya-oc
Copy link
Contributor

yuya-oc commented May 14, 2018

Added some tweak at 152bcf1 Would you check?

@amyblais
Copy link
Member Author

Thanks Yuya!

CHANGELOG.md Outdated
- Fixed Mac and Linux crashing after toggling "Show Mattermost icon in menu bar" app setting.
- Updated design for loading animation icon.
[#748](https://github.com/mattermost/desktop/issues/748)
- Enabled Certificate Transparency verification in HTTPS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuya-oc Which change was this? I'm not sure I understand it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonblais It has been effective since merging #741. #743 had disabled the Certificate Transparency verification in v4.0.1 app though, I had added a version check of Electron.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I remember now. Wondering if we need to include it in changelog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It improves reliability of HTTPS, but it affects connectivity if server certificates are still not adapted to Certificate Transparency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense. Would it be appropriate to link to https://www.certificate-transparency.org/what-is-ct for those who don't know what certificate transparency is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be helpful!

@jasonblais
Copy link
Contributor

@amyblais Made a few updates, primarily moved all crash related fixes under "stability improvements" and added a few missing items.

Are docs for the release also in progress?

@yuya-oc
Copy link
Contributor

yuya-oc commented May 15, 2018

Updated about GPU hardware acceleration option due to #799: 64808a4

@jasonblais
Copy link
Contributor

Thanks @yuya-oc! Made a minor tweak (moved GPU option to stability section and noted the change to ZIP files for Mac):

edc2f4d

If it looks good we can merge @yuya-oc @amyblais

Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jasonblais jasonblais merged commit e71881f into release-4.1 May 15, 2018
@jasonblais jasonblais deleted the amyblais-patch-2 branch May 15, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants