Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows uninstaller not removing files correctly #561

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Jul 11, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix Windows uninstaller not removing files correctly

Multiple async tasks were not performed completely when running uninstaller.
So rearranged tasks with sequential order.
i.e. take care startup registry, finally call electron-squirrel-startup.

Issue link
#551

Test Cases

  1. Install the app with the installer.
  2. Enable "Start app on login" option.
  3. Uninstall the app.
  4. Files under C:\Users\%USERNAME%\AppData\Local\mattermost should be removed excepting .dead and Update.exe.
  5. Registry key \HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run\Mattermost should be removed.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/280#artifacts/containers

Multiple async tasks were not performed completely when running uninstaller.
So rearranged tasks with sequential order.
i.e. take care startup registry, finally call electron-squirrel-startup.
@jasonblais
Copy link
Contributor

@yuya-oc Works as expected. 👍

I guess the files in C:\Users\%USERNAME%\AppData\Roaming\Mattermost should still be there?

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Jul 12, 2017

Yeah, it contains user's configuration. So the uninstaller should not remove it without confirmation.

@jasonblais
Copy link
Contributor

Sounds good, thanks!

@yuya-oc yuya-oc merged commit aad60e2 into mattermost:master Jul 12, 2017
@yuya-oc yuya-oc deleted the fix-windows-uninstaller branch July 12, 2017 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants