Update dependencies #536
Merged
Update dependencies #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I've downloaded the artifact and will test it out this week. I'll also review NOTICE.txt, thanks for preparing it |
jasonblais
approved these changes
May 18, 2017
|
I've been testing this out and have no issues. The only one that started appearing is #537 but it's not related to this PR. Have also reviewed NOTICE.txt and looks good, thanks Yuya! |
jasonblais
reviewed
May 19, 2017
| "electron": "1.6.2", | ||
| "electron-builder": "^14.5.3", | ||
| "electron-builder-squirrel-windows": "^15.0.0", | ||
| "electron": "1.6.6", |
There was a problem hiding this comment.
Do we still want to wait until we update to 1.6.8? That version of Electron was needed for this PR #341
There was a problem hiding this comment.
1.6.8 was still beta when I created this PR. And 1.6.7 has important changes for Windows.
- Desktop notification for Windows 7
- Per-monitor DPI awareness for Windows 8.1/10
So I want to take 1.6.6 for now.
|
Thanks for testing! I will check #537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Update dependencies and devDependencies.
React 15.5 has some deprecation. https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
In this PR, I used drop-in replacements,
prop-types,create-react-classandreact-transition-group.So we need to review NOTICE.txt.
Issue link
#532
Test Cases
Installation and normal usage.
For UI part, CircleCI would do automated tests.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/253#artifacts