Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus to the next top-level window when close the main window #464

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Mar 11, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Set focus to the next top-level window when the main window has been closed.

Issue link
#430, #431

Test Cases

#430

  1. Open Mattermost and another application window.
  2. Activate Mattermost window.
  3. Close Mattermost window.
  4. Another window should get focus.

#431

  1. Open Mattermost and another application window.
  2. Activate Mattermost window.
  3. Close Mattermost.
  4. Show the classic Alt+Tab switcher. (See [Help Wanted] Mattermost desktop app icon appears in the "classic" Alt+Tab switcher list after app window is closed #431)
  5. Mattermost should not appear on the switcher.

Additional Notes
Testable apps: https://circleci.com/gh/yuya-oc/desktop/187#artifacts

@jasonblais
Copy link
Contributor

jasonblais commented Mar 11, 2017

Works great, thanks @yuya-oc!

Tested both cases above. Also confirmed that after minimizing the app, the next top-level app got focus.

/ cc @nmatt the bug fixes for #430 and #431 should be resolved on the next desktop release (v3.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants