[MM-61864] Fix issue where the app will not restore when opened again from cold, fix issue where deep linking from cold didn't work on Linux #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from cold, fix issue where deep linking from cold didn't work on Linux
devinbinnie
added
2: Dev Review
marianunez
approved these changes
Nov 19, 2024
Co-authored-by: Maria A Nunez <[email protected]>
hmhealey
approved these changes
Nov 19, 2024
hmhealey
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Nov 19, 2024
… from cold, fix issue where deep linking from cold didn't work on Linux (#3214) * [MM-61864] Fix issue where the app will not restore when opened again from cold, fix issue where deep linking from cold didn't work on Linux * Update src/main/app/initialize.ts Co-authored-by: Maria A Nunez <[email protected]> --------- Co-authored-by: Maria A Nunez <[email protected]> (cherry picked from commit fad05fd)
mattermost-build
added
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
Nov 19, 2024
… from cold, fix issue where deep linking from cold didn't work on Linux (#3214) (#3215) * [MM-61864] Fix issue where the app will not restore when opened again from cold, fix issue where deep linking from cold didn't work on Linux * Update src/main/app/initialize.ts Co-authored-by: Maria A Nunez <[email protected]> --------- Co-authored-by: Maria A Nunez <[email protected]> (cherry picked from commit fad05fd) Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After fixing #3201, I introduced a bug where the app would not restore its window when booting a second instance, due to the removal of
MainWindow.show(), which was removed since it interfered with the normal app boot process from cold. I also noticed that from cold, Linux would ignore deep links.This PR fixes both of the above issues.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61864