Use default electron implementation for zoomin, zoomout and resetzoom

[razzeee]

This is a possible followup to #187

The three zoom related menu items are now handled by electron itself.

[jasonblais]

Great, thank you @razzeee!!

Would we have two people in the community to help test the pull request? You can download the builds below:

• 64-bit Windows
• 32-bit Windows
• Mac OS X
• Linux

Other artifacts can also be found here.

[yuya-oc]

On OS X, the shortcuts are working. But this PR requires Electron v1.3. Because of discussion in #214, we should not use v1.3 now. So unfortunately we should not merge this.

[jasonblais]

Once this is merged, will it resolve some of the zoom in/out issues on the desktop app? Or would that be a separate issue?

Above: When increasing font size, the chat area somehow shrinks to the top left corner. When decreasing font size, it expands towards bottom right causing the scrollbar to be hidden

^Tested on 1.3 and it reproduced there too, so not a new issue. Doesn't always repro, maybe 30% of the time for me on Windows 10

[yuya-oc]

@razzeee Now we can consider this PR. Possibly does this resolve the issue reported on the previous comment and #334?

[razzeee]

It might, we'll need to test it

[razzeee]

Rebased, but doesn't seem to solve #334

[jasonblais]

Tested on Windows, can confirm that it doesn't solve #334.

For the PR itself, only the following shortcuts work:

• zoom in: CTRL + =
• zoom out: CTRL + MINUS
• reset zoom: CTRL+0

Specifically, CTRL+SHIFT+= and CTRL+PLUS no longer work for zooming in.

EDIT: Used these artifacts to test: https://circleci.com/gh/Razzeee/desktop/53#artifacts

[yuya-oc]

Probably need to add some hidden accelerators for zooming in.

[jasonblais]

If we add two accelerators for CTRL+SHIFT+= and CTRL+PLUS, propose we also add CTRL+SHIFT+MINUS for zooming out at the same time

[razzeee]

This PR wasn't about adding featues/keystrokes. It should be exactly the same we already have, see https://github.com/electron/electron/blob/9c19b4e3d5bd9a17d46b09e7ee1ebd6fc2fefc30/lib/browser/api/menu-item-roles.js#L119

[jasonblais]

CTRL+SHIFT+= and CTRL+PLUS already work though, so we shouldn't remove that functionality.

I'm fine adding CTRL+SHIFT+MINUS on a separate PR in the future.

[razzeee]

• CTRL+SHIFT+= never did work for me, probably due to german keyboard
• CTRL+PLUS does still works for me

[yuya-oc]

Tested on Windows 10 with japanese keyboard.

• CTRL+SHIFT+= is not applicable because the combination is impossible on the keyboard.
• CTRL+PLUS works as CTRL+SHIFT+;. CTRL+; also works.

[yuya-oc]

On english keyboard, CTRL+PLUS works as CTRL+SHIFT+=, and CTRL+= also works.
I noticed one thing, the behavior is different depends on focus inside of the window.

When clicking a tab bar, the behavior is same with original one. But when clicking the webview, only it is zoomed, and the region is correct.

[jasonblais]

I started with a completely fresh install, and it seems to be working now..

Thanks again @razzeee and @yuya-oc, ready to merge.

One interesting note: I tried with win64.zip and #334 wasn't reproducing. It only reproduced on the installer.

[yuya-oc]

@jasonblais Please let me confirm, did you met the behavior like my previous gif?

[jasonblais]

When clicking a tab bar, the behavior is same with original one. But when clicking the webview, only it is zoomed, and the region is correct.

Sorry for missing the note below the GIF.

I just tested and you're correct, the issue only reproduces after clicking on the tab bar. Tried on both the .exe and .zip files for 64-bit Windows.

Note: in v3.4.1 the issue described in #334 occurs whether you've clicked on the webview or the tab bar, at least on 64-bit Windows installer. So this would be an improvement to it.

[razzeee]

For reference electron/electron#7375

[yuya-oc]

Thanks all! Yeah, #334 is improved compared to v3.4.1.
From the result, we have to try to keep the focus of webview as possible.