Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] [Tiling WM] Close button doesn't work. #1510

Closed
3 tasks done
jankaifer opened this issue Mar 17, 2021 · 3 comments
Closed
3 tasks done

[Linux] [Tiling WM] Close button doesn't work. #1510

jankaifer opened this issue Mar 17, 2021 · 3 comments

Comments

@jankaifer
Copy link

I confirm (by marking "x" in the [ ] below: [x]):


Summary
Clicking the close button won't close the window. It might minimize the window on other platforms. But many tiling WMs do not support minimizing (i3 for example). So it just ignores clicking the close button.

Environment

  • Operating System: NixOS (Linux) + i3-gaps
  • Mattermost Desktop App version: 4.5.2
  • Mattermost Server version: 5.32.1

Steps to reproduce
Click the close button.
Press Ctrl+W.
Click option in menu Window > Close.
Make my WM send a signal through the WM_DELETE protocol.

Expected behavior
The application will close.

Observed behavior
It won't close.
I need to send it SIGTERM, SIGKILL, or use xkill.

Possible fixes
Handle close events properly.

@jankaifer
Copy link
Author

jankaifer commented Mar 17, 2021

The issue is here:

if (global.willAppQuit) { // when [Ctrl|Cmd]+Q
saveWindowState(boundsInfoPath, mainWindow);
} else { // Minimize or hide the window for close button.
event.preventDefault();

Confirmed that Ctrl+Q does close the application.

However these:

Click the close button.
Press Ctrl+W.
Click option in menu Window > Close.
Make my WM send a signal through the WM_DELETE protocol.

Still do not work.

@Willyfrog
Copy link
Contributor

we already have an issue to track this, so I'm adding yours to the list of related issues.

@jankaifer
Copy link
Author

Cool, sorry that I missed those.
Closing this one as duplicate of:
#1415
#1266
#90
#962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants