Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close the application window on Linux #1415

Closed
3 tasks done
plaperdr opened this issue Nov 17, 2020 · 3 comments
Closed
3 tasks done

Can't close the application window on Linux #1415

plaperdr opened this issue Nov 17, 2020 · 3 comments

Comments

@plaperdr
Copy link

I confirm (by marking "x" in the [ ] below: [x]):


Summary
Using the X to close the application window on Linux does not work. It either minimizes the application or does not do anything.

Environment

  • Operating System: Ubuntu 20.04 - Gnome 3.36.3
  • Mattermost Desktop App version: 4.6.1
  • Mattermost Server version: 5.26.2

Steps to reproduce

  1. Open the Mattermost application.
  2. Click on the X on the top right of the application.

Expected behavior
The application should quit.

Observed behavior
Two behaviors are observed:

  • By clicking on the X, the application minimizes despite "Leave app running in notifications area when application window is closed" being unchecked.
  • In Gnome Activities screen, clicking on the X does not do anything.

Possible fixes
Probably change this line to "mainWindow.close()" ?
https://github.com/mattermost/desktop/blob/master/src/main/mainWindow.js#L137

@Willyfrog
Copy link
Contributor

hello! and thanks for reporting.
we are aware of the issue and working to fix it in a future release.

Meanwhile, I'll close the issue as it is already reported here

Feel free to reopen if you feel it is a different kind of issue.

@esethna
Copy link
Contributor

esethna commented Nov 17, 2020

@Willyfrog do we have a JIRA bug ticket to track this? If not let's open one and share the link here and in the other issue? Seems the solution was identified here if this is the same issue?

Also the issue that originated the thread is this one. Is this the same issue or different than the one linked above ^? In either case we should reopen it

@Willyfrog
Copy link
Contributor

there are different complains depending on how people is used to close the app.

i've created a ticket to try and fix all of them and try to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants