[MM-53432] Improvements #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
jupenur
reviewed
Nov 15, 2023
cpoile
approved these changes
Nov 15, 2023
| Segment: Segment{ | ||
| Text: "test sentence", | ||
| }, | ||
| Speaker: "うずまき ナルト", |
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Nov 16, 2023
* Implement speech detection step to improve transcription accuracy * Update build files * Add comments * [MM-53432] Improvements (#4) * Implement more human friendly filenames * Include Silero VAD model v4 * Cache CGO dependencies and Whisper models in Docker build * Update silero-vad-go * Add SHA check for ONNXRuntime * Support language autodetection * Initial multi-threading support * Fix marshaling case * Tune speech detector silence duration threshold * Sanitize Text and Speaker strings * Build as position-independent executable * Update rtcd client dependency * Better escaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing some fixes and improvements. (see commits)
@jupenur I am addressing here the requests from previous PRs. Please take a look.
Related PR
mattermost/mattermost-plugin-calls#565