Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for JIRA ticket to full URL #78

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Add test case for JIRA ticket to full URL #78

merged 2 commits into from
Jan 20, 2020

Conversation

grubbins
Copy link
Contributor

In my organisation, we use the plugin to go from either:

  • JIRA-1234, or
  • https://jira/browse/JIRA-1234
    to a shortened [JIRA-1234](https://jira/browse/JIRA-1234/stuff) link. This did not work in earlier versions of the plugin so we have for a while been running my forked version - however, I believe this now works. I just wanted to reflect this in the unit tests.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 15, 2019
hanzei
hanzei approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@hanzei hanzei requested a review from levb November 15, 2019 04:31
levb
levb approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@levb levb added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Nov 18, 2019
@levb
Copy link
Contributor

levb commented Nov 18, 2019

Needs #80 to fix the build, also @grubbins did you have a chance to sign the CLA? Or is our CLA bot mis-functioning?

@levb levb removed the 2: Dev Review Requires review by a core committer label Nov 18, 2019
@grubbins
Copy link
Contributor Author

I am working on getting the CLA signed - need to clear this with my employer.

@mattermod
Copy link
Contributor

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

@jasonblais jasonblais added the Awaiting Submitter Action Blocked on the author label Nov 29, 2019
@jasonblais
Copy link
Contributor

/check-cla

@hanzei
Copy link
Contributor

hanzei commented Jan 20, 2020

/update-branch

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed Awaiting Submitter Action Blocked on the author Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Lifecycle/1:stale labels Jan 20, 2020
@hanzei hanzei merged commit 542fab8 into mattermost-community:master Jan 20, 2020
@hanzei
Copy link
Contributor

hanzei commented Jan 20, 2020

Thanks for adding this test case @grubbins 👍

@jfrerich jfrerich mentioned this pull request Mar 19, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grubbins @levb @mattermod @jasonblais @hanzei