Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-207] Added CRUD operations in autolink plugin #213

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[GH-207] Added CRUD operations in autolink plugin #213

wants to merge 8 commits into from
+336 −7

Conversation

Kshitij-Katiyar
Copy link

@Kshitij-Katiyar Kshitij-Katiyar commented Apr 10, 2023 •
edited
Loading

Summary

  • The Autolink Client API currently only supports Add operation only. So added CRUD operations in the Autolink plugin.

Issue

@Kshitij-Katiyar
[MI-2949]:Added Delete and Get API and their clients in autolink plug…
492a6f2 
…in (#1)

* [MI-2949]:Added Delete and Get API and their clients in autolink plugin

* [MI-2949]:Fixed review comments

* [MI-2949]:Fixed review comments

* [MI-2949]:Fixed review commengts
@mattermost-build
Copy link
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Kshitij-Katiyar
Copy link
Author

@m1lt0n Not able to add you as a reviewer here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@mkdbns mkdbns mentioned this pull request Apr 28, 2023
Open
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Lifecycle/1:stale labels May 21, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

mgdelacroix
mgdelacroix requested changes Jun 27, 2023
View reviewed changes
server/api/api.go Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jun 27, 2023
Merged
@Kshitij-Katiyar
Copy link
Author

@mgdelacroix Please re-review

mgdelacroix
mgdelacroix reviewed Jun 29, 2023
View reviewed changes
Copy link

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes @Kshitij-Katiyar! Some more comments left

server/autolinkclient/client.go Show resolved Hide resolved
server/autolinkclient/client.go Show resolved Hide resolved
server/api/api.go Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
server/api/api.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
server/autolinkclient/client.go Outdated Show resolved Hide resolved
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jun 29, 2023
Merged
@Kshitij-Katiyar
[MI-3218]: Fixed review comments 'Add CRUD operations' (#3)
0a0cf02 
* [MI-3218]:Fixed review comments 'Add CRUD operations'

* [MI-3218]:Fixed review comments
mgdelacroix
mgdelacroix approved these changes Jun 29, 2023
View reviewed changes
Copy link

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kshitij-Katiyar, LGTM! 👍

@mgdelacroix
Copy link

@Kshitij-Katiyar could you please add some tests on the endpoints?

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-autolink that referenced this pull request Jul 6, 2023
@Kshitij-Katiyar
[MI-3267]:Added test cases for PR mattermost-community#213 'Add CRUD …
78c7e8b 
…operations'
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jul 6, 2023
Merged
@Kshitij-Katiyar
[MI-3267]:Added test cases for PR mattermost-community#213 'Add CRUD …
ac38e19 
…operations' (#4)

* [MI-3267]:Added test cases for PR mattermost-community#213 'Add CRUD operations'

* [MI-3267]:Fixed review comments

* [MI-3267]:Fixed review comments

* [MI-3267]:Fixed review comments
@Kshitij-Katiyar
Copy link
Author

@Kshitij-Katiyar could you please add some tests on the endpoints?

@mgdelacroix Added unit test cases.

@hanzei
Copy link
Contributor

hanzei commented Sep 1, 2023

@mgdelacroix @calebroseland Gentle reminder to review this PR. It's needed for the JIRA plugin.

@calebroseland calebroseland removed their request for review February 28, 2024 22:14
@raghavaggarwal2308
Copy link

@mgdelacroix Gentle reminder for review

@raghavaggarwal2308
Copy link

@mgdelacroix Gentke reminder for review

@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdelacroix mgdelacroix Awaiting requested review from mgdelacroix

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Awaiting Submitter Action Blocked on the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kshitij-Katiyar @mattermost-build @mgdelacroix @hanzei @raghavaggarwal2308