Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from CircleCI to Github Actions #205

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Migrate from CircleCI to Github Actions #205

merged 3 commits into from
Feb 7, 2023

Conversation

spirosoik
Copy link
Contributor 

    #### Summary
    The PR build (CI) is a reusable [required workflow](https://github.com/mattermost/actions-workflows/tree/main/.github/workflows/required_workflows/plugins)  

    #### Ticket Link
    Ticket: https://mattermost.atlassian.net/browse/CLD-4816

@spirosoik
Migrate from CircleCI to Github Actions
13ea3de 
        The PR build (CI) is a reusable [required workflow](https://github.com/mattermost/actions-workflows/tree/main/.github/workflows/required_workflows/plugins). The CD
        part is defined in the repository. In parallel we add the  to define the version of node we need to use to build.

        Ticket: https://mattermost.atlassian.net/browse/CLD-4816
@spirosoik spirosoik requested a review from levb as a code owner February 3, 2023 20:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023 •
edited
Loading

Codecov Report

Base: 40.65% // Head: 40.09% // Decreases project coverage by -0.56% ⚠️

Coverage data is based on head (755d52a) compared to base (1a77ee3).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   40.65%   40.09%   -0.56%     
==========================================
  Files           6        6              
  Lines         674      833     +159     
==========================================
+ Hits          274      334      +60     
- Misses        380      479      +99     
  Partials       20       20
Impacted Files Coverage Δ
server/autolink/autolink.go 51.37% <0.00%> (-5.93%) ⬇️
server/autolinkclient/client.go 67.74% <0.00%> (-4.26%) ⬇️
server/autolinkplugin/plugin.go 92.85% <0.00%> (-0.48%) ⬇️
server/autolinkplugin/command.go 0.00% <0.00%> (ø)
server/autolinkplugin/config.go 34.25% <0.00%> (+0.47%) ⬆️
server/api/api.go 64.19% <0.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@m1lt0n m1lt0n self-requested a review February 7, 2023 09:23
@spirosoik spirosoik merged commit 519157c into master Feb 7, 2023
@spirosoik spirosoik deleted the feat/CLD-4816 branch February 7, 2023 09:38
hanzei
hanzei reviewed Feb 7, 2023
View reviewed changes
lock-missing.txt
@@ -0,0 +1 @@
mattermost-plugin-autolink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#200

@hanzei hanzei added Awaiting Submitter Action Blocked on the author 4: Reviews Complete All reviewers have approved the pull request and removed Awaiting Submitter Action Blocked on the author labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei left review comments

@m1lt0n m1lt0n m1lt0n approved these changes

@levb levb Awaiting requested review from levb

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spirosoik @codecov-commenter @m1lt0n @hanzei