[issue-174] Add Jira Autolink Issue With Comment Test Case #189
Conversation
|
Hello @sibasankarnayak, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 40.79% 40.79%
=======================================
Files 6 6
Lines 679 679
=======================================
Hits 277 277
Misses 382 382
Partials 20 20 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
I'd also like to emphasize the importance of backwards compatibility here. We'll need to test with an existing MM server that is connected to Jira Cloud with at least one project. Then make sure there are not duplicate autolinks present, or at least not duplicate autolink operations being done on the posts. |
hanzei
removed
Lifecycle/1:stale
Awaiting Submitter Action
|
@levb Gentle reminder to review this PR |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
hanzei
added
3: QA Review
| }, | ||
| "Welcome https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210 should link!", | ||
| "Welcome [MM-12345 With Comment #10210](https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210) should link!", | ||
| "Welcome [MM-12345 (comment)](https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210) should link!", | ||
| }, { | ||
| "Comment url replacement multiple times", | ||
| autolink.Autolink{ | ||
| Pattern: "(https://mattermost.atlassian.net/browse/)(?P<project_id>\\w+)(-)(?P<jira_id>\\d+)[?](focusedCommentId)(=)(?P<comment_id>\\d+)", | ||
| Template: "[${project_id}-${jira_id} With Comment #${comment_id}](https://mattermost.atlassian.net/browse/${project_id}-${jira_id}?focusedCommentId=${comment_id})", |
There was a problem hiding this comment.
Suggested change:
Template: "[${project_id}-${jira_id} (comment)](https://mattermost.atlassian.net/browse/${project_id}-${jira_id}?focusedCommentId=${comment_id})",
| "Welcome https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210. should link https://mattermost.atlassian.net/browse/MM-12346?focusedCommentId=10210 !", | ||
| "Welcome [MM-12345 With Comment #10210](https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210). should link [MM-12346 With Comment #10210](https://mattermost.atlassian.net/browse/MM-12346?focusedCommentId=10210) !", | ||
| "Welcome https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210. should link https://mattermost.atlassian.net/browse/MM-12346?focusedCommentId=10210!", | ||
| "Welcome [MM-12345 With Comment #10210](https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210). should link [MM-12346 With Comment #10210](https://mattermost.atlassian.net/browse/MM-12346?focusedCommentId=10210)!", |
There was a problem hiding this comment.
Suggested change:
"Welcome [MM-12345 (comment)](https://mattermost.atlassian.net/browse/MM-12345?focusedCommentId=10210). should link [MM-12346 (comment)](https://mattermost.atlassian.net/browse/MM-12346?focusedCommentId=10210)!",
There was a problem hiding this comment.
Requested some changes here. Can you please take a look at it and change this across the test. There are also some additional places in this file which has the pattern like [MM-12345 With Comment #10210], apart from the lines you have changed, which also needs to be changed across to keep things consistent and clean. Thanks.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Fixing some of the left over suggestion on the PR #185
Ticket Here
Fixes #174