-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autolink admin config parsing #184
Conversation
@dipak-demansol gentle reminder to review this PR |
@hanzei @DHaussermann i'm not able to regenerate the 180 & 181 issue with the master Build. Its working fine with the master build. |
@dipak-demansol Did you test with a clean plugin config i.e. |
Yes |
@dipak-demansol Could you please test with the following steps:
Observed behaviour on Expected behaviour: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei tested as you told and its LGTM, adding the cases with that i tested, pls let me know if i miss any case to test.
- adding two member-Users id in console,those 2 user is able to use autolink slash command.
- after performing First case, in the admin system console i refresh the page and still all data is there and those Two users are able to use to autolink slash command. (its a case that ben told me to check) (issue 181)
- by adding space between the two id, expected result is slash command should not work for both user.:- as expected.
- by adding space before the first id, still both user is able to use the slash command and i don't have any issue with that so it LGTM.
- by adding space before the first id and adding space after the last id, both User are able to use the slash command.
- added the user-id on the config file and restarted the server then i'm able to see that config value in the system-console. (issue 180)
Summary
The plugin was falsely storing it's config in UperCase names, which lead to the webapp not being able to rea
This PR make use of
json.Marshal
to convert the plugin config to anmap[string]Interface{}
and hence json tags are used everywhere now.There is one migration left. If an admin (after updating to this PR) sees the empty list in the system console and inputs something, the existing admin list will be overwritten. Running
/autolink add
or/autolink delete
brings the configuration in the right state again.Ticket Link
#180
#181