-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-38146] Use mattermost-server/v6 #169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 41.57% 41.49% -0.09%
==========================================
Files 6 6
Lines 671 670 -1
==========================================
- Hits 279 278 -1
Misses 375 375
Partials 17 17
Continue to review full report at Codecov.
|
@streamer45 @mickmister This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@DHaussermann This PR is ready for a round of smoke testing. Maybe we can even defer that to the release testing. |
@DHaussermann I'm going to defer the QA approval to release testing. |
Summary
This PR updates the dependency on
github.com/mattermost/mattermost-server
fromv5
tov6
. This ensures the v6 breaking changes propagate quickly to developers using this plugin.Please note that the plugin still works against v5 servers.
Ticket Link
https://mattermost.atlassian.net/browse/MM-38146