Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-38146] Use mattermost-server/v6 #169

Merged
merged 2 commits into from
Sep 7, 2021
Merged

[MM-38146] Use mattermost-server/v6 #169

merged 2 commits into from
Sep 7, 2021

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Aug 25, 2021

Summary

This PR updates the dependency on github.com/mattermost/mattermost-server from v5 to v6. This ensures the v6 breaking changes propagate quickly to developers using this plugin.

Please note that the plugin still works against v5 servers.

Ticket Link

https://mattermost.atlassian.net/browse/MM-38146

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 25, 2021
@hanzei hanzei added this to the v1.3.0 milestone Aug 25, 2021
@hanzei hanzei requested a review from levb as a code owner August 25, 2021 09:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #169 (71aebaa) into master (7f5d45a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   41.57%   41.49%   -0.09%     
==========================================
  Files           6        6              
  Lines         671      670       -1     
==========================================
- Hits          279      278       -1     
  Misses        375      375              
  Partials       17       17              
Impacted Files Coverage Δ
server/autolinkplugin/command.go 0.00% <0.00%> (ø)
server/autolinkplugin/config.go 37.58% <ø> (ø)
server/autolinkplugin/plugin.go 91.93% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5d45a...71aebaa. Read the comment docs.

@hanzei
Copy link
Contributor Author

hanzei commented Sep 2, 2021

@streamer45 @mickmister This is ready for review

Copy link

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hanzei hanzei requested a review from DHaussermann September 2, 2021 07:10
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 2, 2021
@hanzei
Copy link
Contributor Author

hanzei commented Sep 2, 2021

@DHaussermann This PR is ready for a round of smoke testing. Maybe we can even defer that to the release testing.

@hanzei
Copy link
Contributor Author

hanzei commented Sep 7, 2021

@DHaussermann I'm going to defer the QA approval to release testing.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 7, 2021
@hanzei hanzei merged commit 571d6cd into master Sep 7, 2021
@hanzei hanzei deleted the MM-38146_v6 branch September 7, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants