Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Scope documentation #167

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Improve Scope documentation #167

merged 2 commits into from
Aug 3, 2021

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Jul 30, 2021

Summary

Add a wider explanation on how Scopes work, and add an example.

Ticket Link

Fix mattermost/docs#4168

@larkox larkox requested a review from cwarnermm July 30, 2021 14:02
@larkox larkox requested a review from levb as a code owner July 30, 2021 14:02
@larkox larkox added the 2: Dev Review Requires review by a core committer label Jul 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #167 (de8506c) into master (9f8f884) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   41.40%   41.40%           
=======================================
  Files           6        6           
  Lines         669      669           
=======================================
  Hits          277      277           
  Misses        375      375           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8f884...de8506c. Read the comment docs.

@levb levb removed the 2: Dev Review Requires review by a core committer label Aug 3, 2021
Copy link
Contributor

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great docs contribution!!

README.md Outdated Show resolved Hide resolved
@cwarnermm cwarnermm merged commit f55f7ec into master Aug 3, 2021
@cwarnermm cwarnermm deleted the ScopeDocumentation branch August 3, 2021 14:20
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Docathon 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Documentation: Improve scope documentation for autolink plugin
6 participants