Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting fix for command #153

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Formatting fix for command #153

merged 2 commits into from
Apr 5, 2021

Conversation

bbodenmiller
Copy link
Contributor

Summary

Ticket Link

@bbodenmiller bbodenmiller requested a review from levb as a code owner March 27, 2021 01:01
@mattermod
Copy link
Contributor

Hello @bbodenmiller,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei requested changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Would you be open on also updating the Usage text in the following table?

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 28, 2021
@codecov-io
Copy link

codecov-io commented Apr 3, 2021 •
edited
Loading

Codecov Report

Merging #153 (4d8b4e2) into master (681b494) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   40.03%   40.03%           
=======================================
  Files           6        6           
  Lines         602      602           
=======================================
  Hits          241      241           
  Misses        345      345           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681b494...4d8b4e2. Read the comment docs.

@bbodenmiller
Copy link
Contributor Author

@hanzei updated

hanzei
hanzei approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 5, 2021
@hanzei hanzei merged commit 6b9bddd into mattermost-community:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bbodenmiller @mattermod @codecov-io @levb @hanzei