create Dockerfile #86
Conversation
|
Hello @derrick56007, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
Thanks @derrick56007 we need you to sign the CLA to accept your PR, anway, somebody already submitted another PR with a preliminary version of the Dockerfile, so if you want to apply changes to that docker file would be really useful. |
| # Install needed packages and clean up. | ||
| RUN apt-get update \ | ||
| && apt-get install -y curl wget git make gcc g++ ca-certificates --no-install-recommends \ | ||
| # Go installation |
|
|
||
| # Install needed packages and clean up. | ||
| RUN apt-get update \ | ||
| && apt-get install -y curl wget git make gcc g++ ca-certificates --no-install-recommends \ |
There was a problem hiding this comment.
put apt arguments before pacakge names, then sort packages one per line in A-Z order
|
|
||
| WORKDIR /focalboard | ||
|
|
||
| RUN make prebuild && make \ |
There was a problem hiding this comment.
new line per command, keep the && on the previous line
| @@ -0,0 +1,35 @@ | |||
| FROM ubuntu:bionic | |||
There was a problem hiding this comment.
add to README how to build and run the docker container
|
Huh, i completely missed there is already a dockerfile in the main repo. Guess this can be closed |
|
@obbardc thanks for taking the initiative! Are there other ideas or projects you'd be interested in around focalboard? |
Heh, great minds and all that, I put in a basic one yesterday, completely missed this PR! The one I created definitely needs some love though, so please make changes as you see fit! |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
Yes, this can be closed, we already have a docker file and actually @flexo3001 is already improving it in another PR. |
No description provided.