Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to run service in a container #76

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Add Dockerfile to run service in a container #76

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6452a0d
Add Dockerfile to run service in a container
Mar 17, 2021
0b58cf8
Split RUN commands into two layers
Mar 18, 2021
463b38d
Remove apt upgrade following comments on various platforms
Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
FROM ubuntu:latest

RUN apt update
RUN apt upgrade -y
RUN apt install -y wget tar gzip unzip file
RUN wget https://releases.mattermost.com/focalboard/0.5.0/focalboard-server-linux-amd64.tar.gz
RUn unzip -o focalboard-server-linux-amd64.tar.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this RUn typo throw a syntax error?

Also, really this should be one run command so the end result isnt a bunch of unnecessary layers

FROM ubuntu:latest

RUN apt update \
    && apt install -y wget tar gzip unzip file \
    && wget https://releases.mattermost.com/focalboard/0.5.0/focalboard-server-linux-amd64.tar.gz \
    && tar -xvzf focalboard-server-linux-amd64.tar.gz \
    && mv focalboard /opt \
    && rm -f focalboard-server-linux-amd64.tar.gz # cleanup the unnecessary zip to reduce end container size

EXPOSE 8000

WORKDIR /opt/focalboard

CMD /opt/focalboard/bin/focalboard-server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot on the typo, but no, it doesn't throw an error.

As far as the "single command" is concerned, I'd be happy to condense it down to 2 commands - one for the OS and one for Focalboard? Seems like that way we only update the OS layer if it changes, regardless of the application version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonraimondi - I've split it out into two RUN statements instead, would appreciate your feedback?

RUN tar -xvzf focalboard-server-linux-amd64.tar.gz
RUN mv focalboard /opt

EXPOSE 8000

WORKDIR /opt/focalboard

CMD /opt/focalboard/bin/focalboard-server