Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove date format user setting #778

Closed
chenilim opened this issue Jul 25, 2021 · 6 comments · Fixed by #790
Closed

Remove date format user setting #778

chenilim opened this issue Jul 25, 2021 · 6 comments · Fixed by #790
Labels
Enhancement New feature or request Help Wanted Extra attention is needed

Comments

@chenilim
Copy link
Contributor

Now that #715 will be fixed, let's use this ticket to track removing the Date format user setting.

Apologies for the round-about path this took. However, I believe the resulting design (MMMM DD, YYYY) is better overall in avoiding the need for a user setting in the first place.

@chenilim chenilim added the Enhancement New feature or request label Jul 25, 2021
@chenilim
Copy link
Contributor Author

Hi @kamre, not sure why I can't assign this to you, but please use this ticket to submit the PR to remove the user setting. Thank you for all your help on this!

@chenilim chenilim added the Help Wanted Extra attention is needed label Jul 25, 2021
@kamre
Copy link
Contributor

kamre commented Jul 26, 2021

@chenilim @asaadmahmood Should we also change the date format for editing date in the input? Something unambiguous like YYYY-MM-DD

@asaadmahmood
Copy link
Contributor

@kamre If possible, we should make it consistent to the MMMM DD, YYYY

@kamre
Copy link
Contributor

kamre commented Jul 26, 2021

@asaadmahmood I think there is no easy way to parse MMMM DD, YYYY back into Date because Intl doesn't have such functionality. And for different locales it looks really different:
KanbanCardPreviewDateLocales
Even editing this with full names of the months can lead to typos and screwing things up in my understanding.

@asaadmahmood
Copy link
Contributor

asaadmahmood commented Jul 26, 2021

@kamre Then we can just leave the format (in the input picker) as it is for now, as the user is already selecting it by himself and the input probably also gives him a visual indication of the date selected.

@kamre
Copy link
Contributor

kamre commented Jul 27, 2021

@chenilim I have created a branch for this issue based on changes for #715

So after #748 is merged I will create new pull request.

harshilsharma63 pushed a commit that referenced this issue Jul 27, 2021
* Preferred date format removed from user settings.
Date format is always `MM/DD/YYYY` for editing in the input.

* Snapshots for jest tests updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants