Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate timestamp asserter #137

Merged
merged 21 commits into from
Nov 26, 2024
Merged

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Nov 3, 2024

Description

This PR integrates changes from matter-labs/zksync-era/pull/3031 which allows to check timestamp ranges, needed for expiresAt and limits with limitType == Allowance.

TODOs & Blockers

  • make timestamp asserter work with era-test-node -- currently, this has only been tested using local server, which is not suitable for CI
  • supply periodIds array as part of hook data within signature in SDK

Copy link

github-actions bot commented Nov 3, 2024

Visit the preview URL for this PR (updated for commit 158a65f):

https://zksync-auth-server-staging--pr137-lyova-integrate-time-yi60bk6o.web.app

(expires Sun, 10 Nov 2024 05:32:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@ly0va ly0va linked an issue Nov 3, 2024 that may be closed by this pull request
Base automatically changed from lyova-offchain-sessions to main November 14, 2024 10:56
@ly0va ly0va marked this pull request as ready for review November 25, 2024 17:49
@ly0va ly0va enabled auto-merge (squash) November 25, 2024 18:25
@ly0va ly0va disabled auto-merge November 26, 2024 08:30
@ly0va ly0va merged commit eeff83b into main Nov 26, 2024
3 checks passed
@ly0va ly0va deleted the lyova-integrate-timestamp-asserter branch November 26, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add block.timestamp assertions into Session Key Module
3 participants