Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(merkle tree): Fix flaky MerkleTree consistency test #475

Merged
merged 2 commits into from
Nov 17, 2023
Merged

test(merkle tree): Fix flaky MerkleTree consistency test #475

merged 2 commits into from
Nov 17, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 13, 2023

What ❔

Fix duplicate_leaf_index_error test, which sometimes fails in CI.

Why ❔

Failing CI costs time and money.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review November 14, 2023 09:33
@slowli slowli requested a review from a team as a code owner November 14, 2023 09:34
@slowli slowli added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit e8bbf76 Nov 17, 2023
22 checks passed
@slowli slowli deleted the aov-bft-375-fix-flaky-merkle-tree-consistency-test branch November 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@popzxc popzxc Awaiting requested review from popzxc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @RomanBrodetski