feat(state-keeper): Disable some seal criteria for boojum #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
previously approved these changes
Nov 2, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 35.85% 35.83% -0.03%
==========================================
Files 519 519
Lines 27812 27823 +11
==========================================
- Hits 9973 9969 -4
- Misses 17839 17854 +15
☔ View full report in Codecov by Sentry. |
Deniallugo
previously approved these changes
Nov 2, 2023
Deniallugo
reviewed
Nov 2, 2023
core/lib/zksync_core/src/state_keeper/seal_criteria/criteria/geometry_seal_criteria.rs
Outdated
Show resolved
Hide resolved
Deniallugo
approved these changes
Nov 2, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [17.1.0](core-v16.2.0...core-v17.1.0) (2023-11-03) ### ⚠ BREAKING CHANGES * Update to protocol version 17 ([#384](#384)) ### Features * **en:** Cache blocks in `fetch_l2_block` ([#403](#403)) ([b94c845](b94c845)) * Port boojum eth-sender changes ([#293](#293)) ([8027326](8027326)) * **state-keeper:** Disable some seal criteria for boojum ([#390](#390)) ([2343532](2343532)) * Update to protocol version 17 ([#384](#384)) ([ba271a5](ba271a5)) * **vm:** Make calculation for pubdata a bit more percise ([#392](#392)) ([6d0e61c](6d0e61c)) ### Bug Fixes * bump zksolc from yanked version to 1.3.16 ([#348](#348)) ([c32b88f](c32b88f)) * **db-index:** Add missing index from FRI prover jobs ([#334](#334)) ([730447f](730447f)) * **db-query:** use join instead of nested query for FRI prover extracting ([#364](#364)) ([f9cc831](f9cc831)) * **db-query:** use nested query for requeuing FRI prover jobs ([#399](#399)) ([3890542](3890542)) * incorrect directory of intrinsic.rs generated. ([#332](#332)) ([#336](#336)) ([eefaad0](eefaad0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <[email protected]>
toni-calvin
pushed a commit
to lambdaclass/zksync-era
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Disables
InitialWritesCriterion,RepeatedWritesCriterion,L2ToL1LogsCriterionfor post-boojum blocks by setting limit tousize::max.Why ❔
Some circuits are no longer single-instance in boojum
Checklist
zk fmtandzk lint.