fix(api): Propagate fallback errors in traces #3469
Merged
+88
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-tracer-fallback-error
branch
from
fe5ccd6 to
c43a8f4
Compare
perekopskiy
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hopefully) fixes #3394
See the issue for the context.
Looks like some old transactions do not have error stored for out-of-gas errors. However, we know that they're failed, and we know that based on the error field from the transactions table.
This PR adds a "fallback" error -- if no other error is detected in the call trace, we use the error from the sequencer.
Granted, I do not have access to the mainnet DB, so not sure what error messages are inside, but if I am to guess, it will be more or less adequate. 😅