Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove unused CUDA_ARCH 60,70 #3357

Merged
merged 1 commit into from
Dec 3, 2024
Merged

ci: Remove unused CUDA_ARCH 60,70 #3357

merged 1 commit into from
Dec 3, 2024

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Dec 3, 2024

What ❔

Remove unneeded CUDA_ARCH 60 and 70.
Move needed CUDA_ARCH to default, so actual list will be in a single place after old CI cleanup.
Remove CUDA_ARCH from witness-generator build, it isn't used there.

Why ❔

To decrease build time and binary size.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

ref ZKD-2123

Move needed CUDA_ARCH to default, so actual list will be in a single
place after old CI cleanup.
Remove CUDA_ARCH from witness-generator build, it isn't used there.

ref ZKD-2123
@yorik yorik requested a review from a team as a code owner December 3, 2024 11:29
@yorik yorik enabled auto-merge December 3, 2024 11:29
@yorik yorik changed the title ci: Remove unneeded CUDA_ARCH 60,70 ci: Remove unused CUDA_ARCH 60,70 Dec 3, 2024
@yorik yorik requested a review from EmilLuta December 3, 2024 13:04
@yorik yorik added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit de4b56d Dec 3, 2024
34 checks passed
@yorik yorik deleted the ya-cuda-arch-cleanup branch December 3, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants