Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix tags processing in core reusable template #3310

Merged
merged 3 commits into from
Nov 20, 2024
Merged

ci: fix tags processing in core reusable template #3310

merged 3 commits into from
Nov 20, 2024

Conversation

otani88
Copy link
Contributor

@otani88 otani88 commented Nov 20, 2024 •
edited
Loading

What ❔

Fix docker tag in core reusable template

Why ❔

EN alpha part was missed in tag

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@otani88 otani88 marked this pull request as ready for review November 20, 2024 07:34
@otani88 otani88 requested a review from a team as a code owner November 20, 2024 07:34
@otani88 otani88 enabled auto-merge November 20, 2024 07:41
@otani88 otani88 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 5aee501 Nov 20, 2024
32 checks passed
@otani88 otani88 deleted the fix_image_tag branch November 20, 2024 08:29
Deniallugo pushed a commit that referenced this pull request Nov 21, 2024
@otani88 @Deniallugo
ci: fix tags processing in core reusable template (#3310)
dc304f1 
## What ❔
Fix docker tag in core reusable template

## Why ❔
EN alpha part was missed in tag

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artmakh artmakh artmakh approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otani88 @artmakh