Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Make prover e2e test mandatory #3305

Merged
merged 2 commits into from
Nov 19, 2024
Merged

ci: Make prover e2e test mandatory #3305

merged 2 commits into from
Nov 19, 2024

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Nov 19, 2024 •
edited by yorik
Loading

What ❔

Make prover e2e test mandatory for merging the PRs
Fix prover e2e test

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

fix ZKD-2081

@Artemka374 Artemka374 requested a review from a team as a code owner November 19, 2024 11:00
@yorik yorik changed the title feat: Make prover e2e test mandatory ci: Make prover e2e test mandatory Nov 19, 2024
yorik
yorik reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@yorik yorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also attach it to https://linear.app/matterlabs/issue/ZKD-2081/make-e2e-prover-test-in-zksync-era-mandatory ?

.github/workflows/ci-prover-e2e.yml Show resolved Hide resolved
@EmilLuta EmilLuta enabled auto-merge November 19, 2024 12:33
@EmilLuta EmilLuta added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit eee7429 Nov 19, 2024
45 checks passed
@EmilLuta EmilLuta deleted the afo/make-prover-e2e-mandatory branch November 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

@yorik yorik yorik approved these changes

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artemka374 @yorik @EmilLuta