Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prover): Remove unneeded dependencies, add default for graceful_shutdown_timeout #3242

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(prover): Remove unneeded dependencies, add default for graceful_shutdown_timeout #3242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions prover/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions prover/crates/bin/prover_autoscaler/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ keywords.workspace = true
categories.workspace = true

[dependencies]
zksync_core_leftovers.workspace = true
zksync_vlog.workspace = true
zksync_utils.workspace = true
zksync_types.workspace = true
zksync_config = { workspace = true, features = ["observability_ext"] }
zksync_prover_job_monitor.workspace = true

Expand Down
5 changes: 4 additions & 1 deletion prover/crates/bin/prover_autoscaler/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ use zksync_config::configs::ObservabilityConfig;
#[derive(Debug, Clone, PartialEq, Deserialize)]
pub struct ProverAutoscalerConfig {
/// Amount of time ProverJobMonitor will wait all it's tasks to finish.
#[serde(with = "humantime_serde")]
#[serde(
with = "humantime_serde",
default = "ProverAutoscalerConfig::default_graceful_shutdown_timeout"
)]
pub graceful_shutdown_timeout: Duration,
pub agent_config: Option<ProverAutoscalerAgentConfig>,
pub scaler_config: Option<ProverAutoscalerScalerConfig>,
Expand Down
Loading