Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zkstack): Introduce build and wait subcommands for components #3240

Merged
merged 17 commits into from
Nov 12, 2024
Merged

feat(zkstack): Introduce build and wait subcommands for components #3240

merged 17 commits into from
Nov 12, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 8, 2024 •
edited
Loading

What ❔

  • Introduces build and wait subcommands for server, EN and contract verifier.
  • Uses these commands in CI (integration tests job).

Why ❔

These commands help preventing races between compilation and test logic.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

ci: Eliminate races between compilation and test logic in integration tests

slowli
slowli commented Nov 11, 2024
View reviewed changes
Copy link
Contributor Author

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vast majority of the changes are autocompletion scripts.

@slowli slowli marked this pull request as ready for review November 11, 2024 11:14
@slowli slowli requested a review from a team as a code owner November 11, 2024 11:14
@slowli slowli requested a review from Deniallugo November 11, 2024 18:48
@slowli slowli added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit e92b806 Nov 12, 2024
33 checks passed
@slowli slowli deleted the aov-pla-1065-protect-against-races-in-ci-integration-tests branch November 12, 2024 14:15
@zksync-era-bot zksync-era-bot mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artmakh artmakh artmakh approved these changes

@popzxc popzxc popzxc approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slowli @Deniallugo @popzxc @artmakh