feat(zk_toolbox): added support for setting attester committee defined in a separate file #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
pompon0
force-pushed
the
gprusak-command-nits
branch
from
3f462aa to
121b015
Compare
brunoffranca
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
LGTM. You might want to wait for @Deniallugo to have a quick look.
brunoffranca
approved these changes
Oct 9, 2024
onyxet
approved these changes
Oct 9, 2024
This was referenced Oct 9, 2024
matias-gonz
pushed a commit
that referenced
this pull request
Oct 9, 2024
…d in a separate file (#2992) So far only setting committee to the value in genesis was supported which is too constraining for real world use. I've added support for specifying the attester committee in a separate yaml file and passing it to the set-attester-committee command.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## [24.29.0](core-v24.28.0...core-v24.29.0) (2024-10-14) ### Features * Add initial version prover_autoscaler ([#2993](#2993)) ([ebf9604](ebf9604)) * add metric to track current cbt ratio ([#3020](#3020)) ([3fd2fb1](3fd2fb1)) * **configs:** Add port parameter to ConsensusConfig ([#2986](#2986)) ([25112df](25112df)) * **configs:** Add port parameter to ConsensusConfig ([#3051](#3051)) ([038c397](038c397)) * **consensus:** smooth transition to p2p syncing (BFT-515) ([#3075](#3075)) ([5d339b4](5d339b4)) * **consensus:** Support for syncing blocks before consensus genesis over p2p network ([#3040](#3040)) ([d3edc3d](d3edc3d)) * **en:** periodically fetch bridge addresses ([#2949](#2949)) ([e984bfb](e984bfb)) * **eth-sender:** add time_in_mempool_cap config ([#3018](#3018)) ([f6d86bd](f6d86bd)) * **eth-watch:** catch another reth error ([#3026](#3026)) ([4640c42](4640c42)) * Handle new yul compilation flow ([#3038](#3038)) ([4035361](4035361)) * **state-keeper:** pre-insert unsealed L1 batches ([#2846](#2846)) ([e5b5a3b](e5b5a3b)) * **vm:** EVM emulator support – base ([#2979](#2979)) ([deafa46](deafa46)) * **zk_toolbox:** added support for setting attester committee defined in a separate file ([#2992](#2992)) ([6105514](6105514)) * **zk_toolbox:** Redesign zk_toolbox commands ([#3003](#3003)) ([114834f](114834f)) * **zktoolbox:** added checking the contract owner in set-attester-committee command ([#3061](#3061)) ([9b0a606](9b0a606)) ### Bug Fixes * **api:** Accept integer block count in `eth_feeHistory` ([#3077](#3077)) ([4d527d4](4d527d4)) * **api:** Adapt `eth_getCode` to EVM emulator ([#3073](#3073)) ([15fe5a6](15fe5a6)) * bincode deserialization for VM run data ([#3044](#3044)) ([b0ec79f](b0ec79f)) * bincode deserialize for WitnessInputData ([#3055](#3055)) ([91d0595](91d0595)) * **external-node:** make fetcher rely on unsealed batches ([#3088](#3088)) ([bb5d147](bb5d147)) * **state-keeper:** ensure unsealed batch is present during IO init ([#3071](#3071)) ([bdeb411](bdeb411)) * **vm:** Check protocol version for fast VM ([#3080](#3080)) ([a089f3f](a089f3f)) * **vm:** Prepare new VM for use in API server and fix divergences ([#2994](#2994)) ([741b77e](741b77e)) ### Reverts * **configs:** Add port parameter to ConsensusConfig ([#2986](#2986)) ([#3046](#3046)) ([abe35bf](abe35bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only setting committee to the value in genesis was supported which is too constraining for real world use. I've added support for specifying the attester committee in a separate yaml file and passing it to the set-attester-committee command.