feat(contract-verifier): Add support for zksolc v1.3.15 to contract verifier #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere and
otani88
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 34.40% 34.40%
=======================================
Files 519 519
Lines 28086 28086
=======================================
+ Hits 9662 9663 +1
+ Misses 18424 18423 -1 ☔ View full report in Codecov by Sentry. |
AnastasiiaVashchuk
approved these changes
Oct 23, 2023
popzxc
approved these changes
Oct 24, 2023
| @@ -79,6 +79,10 @@ RUN mkdir -p /etc/zksolc-bin/v1.3.14 \ | |||
| && wget https://github.com/matter-labs/zksolc-bin/raw/main/linux-amd64/zksolc-linux-amd64-musl-v1.3.14 \ | |||
| && mv zksolc-linux-amd64-musl-v1.3.14 /etc/zksolc-bin/v1.3.14/zksolc \ | |||
| && chmod +x /etc/zksolc-bin/v1.3.14/zksolc | |||
| RUN mkdir -p /etc/zksolc-bin/v1.3.15 \ | |||
There was a problem hiding this comment.
Probably a negative priority suggestion, but if you're feeling funky, I guess it's justified to write a shell script that will do a loop over vararg to turn it into one-liner.
Deniallugo
approved these changes
Oct 24, 2023
|
Closing in favor of #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add support for zksolc v1.3.15 to contract verifier
Why ❔
New zksolc version was released and contract verifier should support it
Checklist
zk fmtandzk lint.