Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zk_inception): Offer a standalone database initialization command #2904

Conversation

doyleish
Copy link
Contributor

@doyleish doyleish commented Sep 17, 2024

What ❔

This change brings database init, migration, into it's own subcommand in zk_inception chain database. It attempts to be backwards compatible, still offering the ability to be run via ecosystem init, or chain init, by introducing a layer of inheritance in the genesis and database arguments.

Also adds genesis skip flags to {ecosystem, chain} init to support the below workflow

Why ❔

The overall goal of this change is to support running chain init in smaller pieces, at different times. My use-case roughly looks like:

- ecosystem create
- l1 contracts deployed
* stand up some infra like db *
- init db
* stand up some runtime for server i.e. k8s *
- server --genesis

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

- Move to chain subcommand
- Support skipping db/genesis during chain init
@doyleish doyleish marked this pull request as ready for review September 17, 2024 22:46
@sanekmelnikov
Copy link
Collaborator

Thank you very much!
We've took these ideas into #2946
Please take a look and see if that's working for you :)

@doyleish doyleish closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants