Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api_server): report gas price based on open batch #2868

Merged
merged 25 commits into from
Jan 13, 2025
Merged

feat(api_server): report gas price based on open batch #2868

merged 25 commits into from
Jan 13, 2025
+627 −104

Conversation

itegulov
Copy link
Contributor

What ❔

api_server should report gas price based on the currently open L1 batch as opposed to the latest sealed L2 block.

Note: adding BatchFeeInput to L1 batch models did not end up being necessary but I think it still makes sense.

Why ❔

To avoid gas fluctuation issues on chains with low amount of traffic

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Base automatically changed from daniyar/unsealed_batches_in_db to main October 10, 2024 10:28
@itegulov itegulov force-pushed the daniyar/pla-1011-gas-price-open-batch branch from d042e29 to 6fd7c94 Compare October 16, 2024 01:33
perekopskiy
perekopskiy reviewed Oct 16, 2024
View reviewed changes
core/node/fee_model/src/lib.rs Outdated Show resolved Hide resolved
core/lib/types/src/fee_model.rs Outdated Show resolved Hide resolved
@itegulov itegulov mentioned this pull request Oct 18, 2024
Merged
4 tasks
@itegulov itegulov force-pushed the daniyar/pla-1011-gas-price-open-batch branch from 7bd7d62 to 47375d3 Compare December 12, 2024 04:43
@itegulov itegulov force-pushed the daniyar/pla-1011-gas-price-open-batch branch 7 times, most recently from 1d8f34e to 6b5b931 Compare December 13, 2024 05:34
@itegulov itegulov requested review from perekopskiy and removed request for a team, yorik, alexandrst88, artmakh, hatemosphere, onyxet, otani88 and iluwaa December 16, 2024 00:32
perekopskiy
perekopskiy previously approved these changes Jan 3, 2025
View reviewed changes
core/node/api_server/src/web3/tests/vm.rs Outdated Show resolved Hide resolved
core/node/api_server/src/web3/tests/vm.rs Outdated Show resolved Hide resolved
perekopskiy
perekopskiy previously approved these changes Jan 7, 2025
View reviewed changes
@itegulov itegulov added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@itegulov itegulov added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit f30aca0 Jan 13, 2025
32 checks passed
@itegulov itegulov deleted the daniyar/pla-1011-gas-price-open-batch branch January 13, 2025 09:38
@zksync-era-bot zksync-era-bot mentioned this pull request Jan 10, 2025
Open
perekopskiy added a commit that referenced this pull request Jan 14, 2025
@perekopskiy
Revert "feat(api_server): report gas price based on open batch (#2868)"
f7ec05c 
This reverts commit f30aca0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy left review comments

@perekopskiy perekopskiy perekopskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itegulov @perekopskiy @thomas-nguy