-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): Add cpu-target for witness_generator compilation #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xVolosnikov
force-pushed
the
vv-use-rustflags-for-witgen
branch
4 times, most recently
from
August 20, 2024 11:34
32115a2
to
ed21bfd
Compare
0xVolosnikov
force-pushed
the
vv-use-rustflags-for-witgen
branch
from
August 20, 2024 12:01
8caee75
to
6aae277
Compare
EmilLuta
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a nit (maybe rename build-push-prover-images-avx512
-> something witness related, as it's all it does), it looks good. I'd test it out thoroughly and ask someone from DevOps to have a look as well.
0xVolosnikov
force-pushed
the
vv-use-rustflags-for-witgen
branch
from
August 20, 2024 14:05
912e472
to
f621883
Compare
0xVolosnikov
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
August 21, 2024 13:07
yorik
approved these changes
Aug 21, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
## What ❔ Same changes as in #2687, but for stage release workflow ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmt
andzk lint
.