Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): Add cpu-target for witness_generator compilation #2687

Merged
merged 11 commits into from
Aug 21, 2024

Conversation

0xVolosnikov
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@0xVolosnikov 0xVolosnikov force-pushed the vv-use-rustflags-for-witgen branch 4 times, most recently from 32115a2 to ed21bfd Compare August 20, 2024 11:34
@0xVolosnikov 0xVolosnikov force-pushed the vv-use-rustflags-for-witgen branch from 8caee75 to 6aae277 Compare August 20, 2024 12:01
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a nit (maybe rename build-push-prover-images-avx512 -> something witness related, as it's all it does), it looks good. I'd test it out thoroughly and ask someone from DevOps to have a look as well.

.github/workflows/build-docker-from-tag.yml Outdated Show resolved Hide resolved
@0xVolosnikov 0xVolosnikov force-pushed the vv-use-rustflags-for-witgen branch from 912e472 to f621883 Compare August 20, 2024 14:05
@0xVolosnikov 0xVolosnikov marked this pull request as ready for review August 21, 2024 13:07
@0xVolosnikov 0xVolosnikov requested a review from a team as a code owner August 21, 2024 13:07
@0xVolosnikov 0xVolosnikov added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 75851ff Aug 21, 2024
55 checks passed
@0xVolosnikov 0xVolosnikov deleted the vv-use-rustflags-for-witgen branch August 21, 2024 14:45
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
## What ❔

Same changes as in #2687,
but for stage release workflow

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants