Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): Fix missing experimental VM config #2629

Merged

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Aug 9, 2024

What ❔

Uses default experimental VM config if one is not supplied when initializing the state keeper.

Why ❔

Otherwise, the state keeper will panic on start if the config is missing. Logically, this config shouldn't be required for it to work (unlike for the VM playground).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review August 9, 2024 13:46
@slowli slowli added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2024
@slowli slowli added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2024
@slowli slowli added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit e07a39d Aug 9, 2024
50 checks passed
@slowli slowli deleted the aov-pla-1009-merge-vm-feature-branch-into-main-fix-config branch August 9, 2024 15:30
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.17.0](core-v24.16.0...core-v24.17.0)
(2024-08-13)


### Features

* Allow tracking l2 fees for L2-based chains
([#2563](#2563))
([e3f7804](e3f7804))
* Remove old EN code
([#2595](#2595))
([8d31ebc](8d31ebc))
* **tee:** introduce get_tee_proofs RPC method for TEE proofs
([#2474](#2474))
([d40ff5f](d40ff5f))
* **vm:** Fast VM integration
([#1949](#1949))
([b752a54](b752a54))


### Bug Fixes

* query for prover API
([#2628](#2628))
([b8609eb](b8609eb))
* **vm:** Fix missing experimental VM config
([#2629](#2629))
([e07a39d](e07a39d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants