Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vlog): Expose more resource values via opentelemetry #2620

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 8, 2024

What ❔

Exposes cluster name and deployment environment in opentelemetry tracing/logs.

Used env vars:

  • CLUSTER_NAME
  • DEPLOYMENT_ENVIRONMENT

Why ❔

Allows collecting data from multiple envs to a single source and then filtering based on resource attributes.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@popzxc popzxc enabled auto-merge August 8, 2024 10:48
@popzxc popzxc added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 7ae07e4 Aug 8, 2024
48 checks passed
@popzxc popzxc deleted the popzxc-otel-more-resources branch August 8, 2024 11:21
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.16.0](core-v24.15.0...core-v24.16.0)
(2024-08-08)


### Features

* External prover API
([#2538](#2538))
([129a181](129a181))
* **node-framework:** Add API fee params resource
([#2621](#2621))
([aff7b65](aff7b65))
* **vlog:** Expose more resource values via opentelemetry
([#2620](#2620))
([7ae07e4](7ae07e4))
* **vlog:** Report observability config, flush, and shutdown
([#2622](#2622))
([e23e661](e23e661))


### Bug Fixes

* Bump prover dependencies & rust toolchain
([#2600](#2600))
([849c6a5](849c6a5))
* **en:** Initialize SyncState in OutputHandler
([#2618](#2618))
([f0c8506](f0c8506))
* restrictive genesis parsing
([#2605](#2605))
([d5f8f38](d5f8f38))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants