Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): Allow running new VM in state keeper #2616

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Aug 7, 2024

What ❔

  • Allows running the new VM in the state keeper.
  • Adds a CI load test with the new VM.

Why ❔

Allows to monitor new VM performance regressions.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli changed the base branch from main to jms-vm2 August 7, 2024 13:17
Copy link
Contributor Author

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to not run the VM playground in integration tests now and instead run the state keeper with the shadow VM mode. I think the VM playground has its benefits; it could to complete integration tests and then fail if the playground has crashed (but this would optimally require to run it in a separate process which I haven't implemented). Would this approach make sense, or is it overly complicated?

Also, the Protobuf compatibility failure is intentional (caused by redefining experimental VM config in place of the VM playground config). It should disappear when comparing the feature branch and main.

@slowli slowli marked this pull request as ready for review August 7, 2024 15:28
@slowli slowli requested a review from a team as a code owner August 7, 2024 15:28
Copy link
Contributor

github-actions bot commented Aug 9, 2024

No performance difference detected (anymore)

@slowli slowli merged commit 7da372f into jms-vm2 Aug 9, 2024
53 of 54 checks passed
@slowli slowli deleted the aov-pla-1010-run-new-vm-in-load-test branch August 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants