fix(zk_toolbox): Get l1-network config param from flag #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Aug 7, 2024
Deniallugo
approved these changes
Aug 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.2](zk_toolbox-v0.1.1...zk_toolbox-v0.1.2) (2024-08-20) ### Features * Poll the main node API for attestation status - relaxed (BFT-496) ([#2583](#2583)) ([b45aa91](b45aa91)) * update base token rate on L1 ([#2589](#2589)) ([f84aaaf](f84aaaf)) * **zk_toolbox:** Add installation script ([#2569](#2569)) ([009cd97](009cd97)) * **zk_toolbox:** Add lint command ([#2626](#2626)) ([3d02946](3d02946)) * **zk_toolbox:** Add observability interactive option ([#2592](#2592)) ([3aeaaed](3aeaaed)) * **zk_toolbox:** Add zk_supervisor run unit tests command ([#2610](#2610)) ([fa866cd](fa866cd)) * **zk_toolbox:** Add zk_supervisor test l1 contracts command ([#2613](#2613)) ([931e452](931e452)) * **zk_toolbox:** Add zk_supervisor test prover command ([#2614](#2614)) ([0fe173b](0fe173b)) * **zk_toolbox:** allow to run `zk_inception chain create` non-interactively ([#2579](#2579)) ([555fcf7](555fcf7)) * **zk_toolbox:** Minting base token ([#2571](#2571)) ([ae2dd3b](ae2dd3b)) * **zk_toolbox:** Run formatters and linterrs ([#2675](#2675)) ([caedd1c](caedd1c)) ### Bug Fixes * Bump prover dependencies & rust toolchain ([#2600](#2600)) ([849c6a5](849c6a5)) * **zk_toolbox:** Do not panic during mint ([#2658](#2658)) ([1a8ee90](1a8ee90)) * **zk_toolbox:** Get l1-network config param from flag ([#2603](#2603)) ([553d307](553d307)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR captures the l1_network param in the
zk_inception ecosystem createif is set through the --l1-network flag.Why ❔
If the tool wants to be used non-iteratively this value should be accepted.
Checklist
zk fmtandzk lint.