fix(node): respect namespaces configuration #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Aug 2, 2024
|
@popzxc, can you merge this pls? I'm not authorized. |
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
🤖 I have created a release *beep* *boop* --- ## [24.15.0](core-v24.14.0...core-v24.15.0) (2024-08-07) ### Features * optimize LWG and NWG ([#2512](#2512)) ([0d00650](0d00650)) * Poll the main node API for attestation status - relaxed (BFT-496) ([#2583](#2583)) ([b45aa91](b45aa91)) * **zk_toolbox:** allow to run `zk_inception chain create` non-interactively ([#2579](#2579)) ([555fcf7](555fcf7)) ### Bug Fixes * **core:** Handle GCS Response retriable errors ([#2588](#2588)) ([4b74092](4b74092)) * **node:** respect namespaces configuration ([#2578](#2578)) ([e2d9060](e2d9060)) * **vm-runner:** Fix data race in storage loader ([1810b78](1810b78)) ### Reverts * "feat: Poll the main node for the next batch to sign (BFT-496)" ([#2574](#2574)) ([72d3be8](72d3be8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Roman Brodetski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Respect the configuration of namespaces when building the HTTP Web3 API layer.
Why ❔
This commit fixes a bug found when trying to run the node server with the following configuration:
This was added to the
etc/env/target/dev.envfile to test PR #2474. It turned out that theunstablenamespace works fine for the WebSocket API but not for the HTTP API.Checklist
zk fmtandzk lint.