refactor(vm-runner): Allow switching between VMs for latest protocol version – follow ups #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
changed the title
slowli
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88,
iluwaa,
montekki,
itegulov,
popzxc and
joonazan
and removed request for
a team,
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
popzxc
reviewed
Aug 2, 2024
| @@ -541,17 +541,70 @@ export class TestContextOwner { | |||
| this.reporter.finishAction(); | |||
| } | |||
|
|
|||
| private async waitForVmPlayground() { | |||
There was a problem hiding this comment.
May I ask you to add somewhat verbose comments on what do these functions do and why do we need them? Because there is a good chance that in the future someone will hard time understanding what's going on in here.
popzxc
approved these changes
Aug 2, 2024
itegulov
approved these changes
Aug 5, 2024
slowli
deleted the
aov-pla-997-allow-switching-between-vms-for-latest-protocol-version-follow-ups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Various follow-ups after #2508:
etc/env.Why ❔
Improves maintainability and test coverage.
Checklist
zk fmtandzk lint.