Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vm): Fix fast VM unit tests #2560

Merged
merged 1 commit into from
Aug 5, 2024
Merged

test(vm): Fix fast VM unit tests #2560

merged 1 commit into from
Aug 5, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Aug 1, 2024

What ❔

Fixes unit tests that previously failed because of incorrect Heap comparisons.

Why ❔

Better test coverage.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review August 1, 2024 11:30
@slowli slowli requested review from joonazan and montekki August 1, 2024 11:30
@slowli slowli merged commit ca37336 into jms-vm2 Aug 5, 2024
57 checks passed
@slowli slowli deleted the aov-pla-1002-fix-test_tracing_of_execution_errors-unit-test branch August 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montekki montekki montekki approved these changes

@joonazan joonazan Awaiting requested review from joonazan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @montekki @joonazan