-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize LWG and NWG #2512
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ff57b38
Move recursive circuits out of AggregationWrapper struct
0xVolosnikov 64fb5b7
Add comments in prover tests
0xVolosnikov 88e610c
Merge branch 'main' into vv-optimize-lwg-nwg
0xVolosnikov 24ef093
Cargo fmt
0xVolosnikov cc583c7
Process LWG in batches
0xVolosnikov 7c261a0
Move LWG processing in separate thread
0xVolosnikov a5105f3
Remove separate thread; cleanup
0xVolosnikov 7b369d5
Fix after merge
0xVolosnikov 69c80f8
Parallelize LWG
0xVolosnikov 9b9c52d
Fix semaphore usage
0xVolosnikov 5a3f20d
Merge branch 'main' into vv-optimize-lwg-nwg
0xVolosnikov 89249e9
Add comments to constants
0xVolosnikov 3ed06aa
Fix todos in basic_test
0xVolosnikov 745461e
Cargo fmt
0xVolosnikov 4b32eb0
Simplify LWG
0xVolosnikov 2dbca20
Parallelize NWG as well
0xVolosnikov b5b9a04
Update deps
0xVolosnikov fb75fc2
Address comments
0xVolosnikov a119262
Cargo.lock
0xVolosnikov 8b6add2
Merge remote-tracking branch 'origin/main' into vv-optimize-lwg-nwg
0xVolosnikov e7e0235
Hotfix
0xVolosnikov 9899892
Cargo fmt
0xVolosnikov 6468ddd
Use max_circuits_in_flight from config
0xVolosnikov c2a5e72
Fix
0xVolosnikov e0694a2
Fix lint issues
0xVolosnikov 0f4db7c
Merge remote-tracking branch 'origin/main' into vv-optimize-lwg-nwg
0xVolosnikov b61d466
Revert unnessesary Cargo.lock changes
0xVolosnikov f8c3236
Add comments
0xVolosnikov 1219f7f
Fix lint issues in tests
0xVolosnikov 752c541
Revert blocking spawns
0xVolosnikov 7486f2d
Cleanup
0xVolosnikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we decided to have a single value for all components. They're somewhat different on usage. I don't think we should change this until the first need, but I can see this popping up soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can override the value per-component, so it should be fine.